Merge linter changes into branch

.gitignore

@@ -142,6 +142,7 @@ dist
 
 # production
 /build
+*/build/
 
 # misc
 .DS_Store

app/package.json

@@ -6,12 +6,12 @@
   "private": true,
   "license": "UNLICENSED",
   "scripts": {
-    "build": "nest build",
+    "build": "npm run lint && nest build",
     "format": "prettier --write \"src/**/*.ts\" \"test/**/*.ts\"",
-    "start": "nest start --watch",
+    "start": "npm run build && nest start --watch",
     "start:debug": "nest start --debug --watch",
     "start:prod": "node dist/main",
-    "lint": "eslint \"{src,apps,libs,test}/**/*.ts\" --fix",
+    "lint": "eslint \"src/**/*.ts\" --fix",
     "test": "jest",
     "test:watch": "jest --watch",
     "test:cov": "jest --coverage",

app/src/app.service.ts

@@ -1,7 +1,13 @@
 import { Injectable, Logger } from '@nestjs/common';
-import { ConnectedSocket, MessageBody, OnGatewayConnection, SubscribeMessage, WebSocketGateway } from '@nestjs/websockets';
+import {
+  ConnectedSocket,
+  OnGatewayConnection,
+  MessageBody,
+  SubscribeMessage,
+  WebSocketGateway,
+} from '@nestjs/websockets';
 import { PlayerService } from './players/player.service';
-import { Socket } from 'socket.io'
+import { Socket } from 'socket.io';
 
 @WebSocketGateway({ cors: true })
 @Injectable()
@@ -9,14 +15,20 @@ export class AppService implements OnGatewayConnection {
   private readonly logger = new Logger(AppService.name);
 
   constructor(private readonly playerService: PlayerService) {}
-  handleConnection(client:Socket) {
+  handleConnection(client: Socket) {
     this.logger.log(client.id);
   }
 
   @SubscribeMessage('example-request')
-  handleCustomEvent(@ConnectedSocket() client:Socket,@MessageBody() data: string): unknown {
+  handleCustomEvent(
+    @ConnectedSocket() client: Socket,
+    @MessageBody() data: string,
+  ): unknown {
     this.logger.debug(`Received request in backend with data: ${data}`);
     this.logger.debug(`Received data id from client: ${client.id}`);
-    return {event: "example-response", data: `Replying from backend, received data: ${data}`};
+    return {
+      event: 'example-response',
+      data: `Replying from backend, received data: ${data}`,
+    };
   }
 }

app/src/players/player.service.ts

@@ -1,5 +1,4 @@
 import { Injectable, Logger } from '@nestjs/common';
-import { MessageBody, OnGatewayConnection, SubscribeMessage, WebSocketGateway } from '@nestjs/websockets';
 
 @Injectable()
 export class PlayerService {

interface/.eslintrc.js

@@ -0,0 +1,17 @@
+module.exports = {
+  parser: "@typescript-eslint/parser",
+  parserOptions: {
+    project: "tsconfig.json",
+    tsconfigRootDir: __dirname,
+    sourceType: "module",
+  },
+  plugins: ["@typescript-eslint/eslint-plugin"],
+  extends: ["plugin:@typescript-eslint/strict", "plugin:prettier/recommended"],
+  root: true,
+  env: {
+    node: true,
+    jest: true,
+  },
+  ignorePatterns: [".eslintrc.js", "dist/"],
+  rules: {},
+};

interface/client-events/ClientEvent.ts

@@ -1,5 +1,5 @@
 export enum ClientEvent {
   CREATE_LOBBY = "create-lobby",
   JOIN_LOBBY = "join-lobby",
-    START_GAME = "start-game"
+  START_GAME = "start-game",
 }

interface/client-events/CreateLobbyEvent.ts

@@ -1,3 +1,3 @@
 export type CreateLobbyEvent = {
   userName: string;
-}
+};

interface/client-events/JoinLobbyEvent.ts

@@ -1,4 +1,4 @@
 export type JoinLobbyEvent = {
   userName: string;
   lobbyId: string;
-}
+};

interface/constants/TrackType.ts

@@ -1,4 +1,4 @@
 export enum TrackType {
   RAIL = "RAIL",
-    ROAD = "ROAD"
+  ROAD = "ROAD",
-};
+}

interface/package.json

@@ -5,13 +5,21 @@
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "scripts": {
-    "test": "echo \"Error: no test specified\" && exit 1",
+    "build": "npm run lint && tsc",
-    "build": "tsc"
+    "lint": "eslint \"*.ts\" \"*/**/*.ts\" --fix"
   },
   "author": "",
   "license": "ISC",
   "devDependencies": {
+    "@eslint/js": "^8.0.0",
     "@types/node": "^22.9.0",
-    "typescript": "^5.6.3"
+    "@typescript-eslint/eslint-plugin": "^8.15.0",
+    "@typescript-eslint/parser": "^8.15.0",
+    "eslint": "^8.0.0",
+    "eslint-config-prettier": "^9.1.0",
+    "eslint-plugin-prettier": "^5.2.1",
+    "globals": "^15.12.0",
+    "typescript": "^5.6.3",
+    "typescript-eslint": "^8.15.0"
   }
 }

interface/server-events/ServerError.ts

@@ -1,4 +1,4 @@
 export enum ServerError {
   CREATE_LOBBY_ERROR = "create-lobby-error",
-    JOIN_LOBBY_ERROR = "join-lobby-error"
+  JOIN_LOBBY_ERROR = "join-lobby-error",
 }

interface/server-events/ServerEvent.ts

@@ -1,4 +1,4 @@
 export enum ServerEvent {
   LOBBY_UPDATE = "lobby-update",
-    START_ROUND = "start-round"
+  START_ROUND = "start-round",
 }

web/.eslintrc.js

@@ -0,0 +1,17 @@
+module.exports = {
+  parser: "@typescript-eslint/parser",
+  parserOptions: {
+    project: "tsconfig.json",
+    tsconfigRootDir: __dirname,
+    sourceType: "module",
+  },
+  plugins: ["@typescript-eslint/eslint-plugin"],
+  extends: ["plugin:@typescript-eslint/strict", "plugin:prettier/recommended"],
+  root: true,
+  env: {
+    node: true,
+    jest: true,
+  },
+  ignorePatterns: [".eslintrc.js", "dist/", "node_modules/", "build/"],
+  rules: {},
+};

web/package.json

@@ -22,9 +22,10 @@
   },
   "scripts": {
     "start": "react-scripts start",
-    "build": "react-scripts build",
+    "build": "npm run lint && react-scripts build",
     "test": "react-scripts test",
-    "eject": "react-scripts eject"
+    "eject": "react-scripts eject",
+    "lint": "eslint \"*/**/*.tsx\" \"*/**/*.ts\" --fix"
   },
   "eslintConfig": {
     "extends": [
@@ -43,5 +44,13 @@
       "last 1 firefox version",
       "last 1 safari version"
     ]
+  },
+  "devDependencies": {
+    "@eslint/js": "^8.0.0",
+    "@typescript-eslint/parser": "^8.15.0",
+    "eslint": "^8.0.0",
+    "eslint-config-prettier": "^9.1.0",
+    "eslint-plugin-prettier": "^5.2.1",
+    "typescript-eslint": "^8.15.0"
   }
 }

web/src/App.test.tsx

@@ -1,8 +0,0 @@
-import React from 'react';
-import { render, screen } from '@testing-library/react';
-import App from './App';
-
-test('Renders hello world', () => {
-  render(<App />);
-  expect(screen.getByText("Hello World! Front")).toBeInTheDocument();
-});

web/src/App.tsx

@@ -1,15 +1,13 @@
-import React from 'react';
+import React from "react";
 import { io } from "socket.io-client";
-import LandingPage from './pages/landing/LandingPage';
+import LandingPage from "./pages/landing/LandingPage";
 
 function App() {
   const socket = io("http://localhost:3010");
-  const emitData = () => console.log(socket.emit("example-request", "custom-request"));
-  socket.on("example-response", (data) => console.log(`Received response in front end with data: ${data}`));
 
   return (
     <div className="App">
-      <LandingPage socket={socket}/>
+      <LandingPage socket={socket} />
     </div>
   );
 }

web/src/index.tsx

@@ -1,13 +1,13 @@
-import React from 'react';
+import React from "react";
-import ReactDOM from 'react-dom/client';
+import ReactDOM from "react-dom/client";
-import App from './App';
+import App from "./App";
-import './App.scss'
+import "./App.scss";
 
 const root = ReactDOM.createRoot(
-  document.getElementById('root') as HTMLElement
+  document.getElementById("root") as HTMLElement,
 );
 root.render(
   <React.StrictMode>
     <App />
-  </React.StrictMode>
+  </React.StrictMode>,
 );

web/src/pages/landing/LandingPage.tsx

@@ -1,12 +1,15 @@
-import React from "react"
+import React, { ChangeEvent } from "react";
 import { Socket } from "socket.io-client";
 
-const LandingPage = (props:{socket:Socket})=>{
+const LandingPage = (props: { socket: Socket }) => {
-    var username = ""; 
+  let username = "";
-    const registerUsername = (event:any) => username = event.target.value;
+  const registerUsername = (event: ChangeEvent<HTMLInputElement>) =>
+    (username = event.target.value);
   const socket = props.socket;
-    const handleCreateLobby = () => socket.emit("create-lobby", {username:username});
+  const handleCreateLobby = () =>
-    return <React.Fragment>
+    socket.emit("create-lobby", { username: username });
+  return (
+    <React.Fragment>
       <div className="LandingPageTitle">
         <h1>Trains And Roads</h1>
       </div>
@@ -21,5 +24,6 @@ const LandingPage = (props:{socket:Socket})=>{
         <button className="JoinLobbyButton secondary">Join Lobby</button>
       </div>
     </React.Fragment>
+  );
 };
 export default LandingPage;

web/src/setupTests.ts

@@ -2,4 +2,4 @@
 // allows you to do things like:
 // expect(element).toHaveTextContent(/react/i)
 // learn more: https://github.com/testing-library/jest-dom
-import '@testing-library/jest-dom';
+import "@testing-library/jest-dom";